[MusicXML] improve title box position#33373
Merged
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThis PR adjusts numeric precision and layout calculation in the MusicXML import/export path: exportmusicxml.cpp formats Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/importexport/musicxml/internal/import/importmusicxmlpass1.cpp (1)
1004-1020:⚠️ Potential issue | 🟠 MajorUse conditional spatium logic consistently on line 1020
Line 1004 conditionally selects the spatium source based on
vbox->sizeIsSpatiumDependent(), but line 1020 unconditionally usesvbox->spatium()for the height-to-Spatium conversion. The padding calculation and height conversion must use the same spatium base.Change line 1020 to:
const double sp = vbox->sizeIsSpatiumDependent() ? vbox->spatium() : vbox->style().defaultSpatium(); const auto height = Spatium::fromAbsolute(calculatedVBoxHeight, sp);This pattern is consistent with similar conversions elsewhere in the codebase (e.g.,
box.cpplines 106-108).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/importexport/musicxml/internal/import/importmusicxmlpass1.cpp` around lines 1004 - 1020, The height conversion uses vbox->spatium() unconditionally but padding above used vbox->sizeIsSpatiumDependent() to pick between vbox->spatium() and vbox->style().defaultSpatium(); update the Spatium::fromAbsolute call to use the same conditional spatium selection as the padding calculation (compute a local sp variable via vbox->sizeIsSpatiumDependent() ? vbox->spatium() : vbox->style().defaultSpatium() and pass that to Spatium::fromAbsolute with calculatedVBoxHeight), referencing vbox, calculatedVBoxHeight and Spatium::fromAbsolute to locate the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/importexport/musicxml/internal/import/importmusicxmlpass1.cpp`:
- Line 1004: The variable padding is declared as int which truncates fractional
spatium values; change its type to double and assign it from
vbox->sizeIsSpatiumDependent() ? vbox->style().spatium() :
vbox->style().defaultSpatium() so the fractional precision from spatium() and
defaultSpatium() is preserved (update any downstream uses of padding to accept
double where necessary).
---
Outside diff comments:
In `@src/importexport/musicxml/internal/import/importmusicxmlpass1.cpp`:
- Around line 1004-1020: The height conversion uses vbox->spatium()
unconditionally but padding above used vbox->sizeIsSpatiumDependent() to pick
between vbox->spatium() and vbox->style().defaultSpatium(); update the
Spatium::fromAbsolute call to use the same conditional spatium selection as the
padding calculation (compute a local sp variable via
vbox->sizeIsSpatiumDependent() ? vbox->spatium() :
vbox->style().defaultSpatium() and pass that to Spatium::fromAbsolute with
calculatedVBoxHeight), referencing vbox, calculatedVBoxHeight and
Spatium::fromAbsolute to locate the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 30a4d7c0-5820-4ad6-912f-f4a2adc5f617
📒 Files selected for processing (3)
src/importexport/musicxml/internal/export/exportmusicxml.cppsrc/importexport/musicxml/internal/import/importmusicxmlpass1.cppsrc/importexport/musicxml/tests/data/testSystemDistance_ref.xml
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 13, 2026
Backport of musescore#33373 Co-Authored-By: Klaus Rettinghaus <rettinghaus@users.noreply.github.com>
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 13, 2026
Backport of musescore#33373 Co-Authored-By: Klaus Rettinghaus <rettinghaus@users.noreply.github.com>
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 13, 2026
Backport of musescore#33373 Co-Authored-By: Klaus Rettinghaus <rettinghaus@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
miiizen
approved these changes
May 15, 2026
Merged
github-project-automation
Bot
moved this from Done
to Needs porting
in MuseScore Studio 4.7.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rounds the
default-xanddefault-ypositions of the title vbox on export for greater stability on import and export.